Remove deprecated Cookie method usage #17006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Faheem-Khan
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi, @M-Faheem-Khan, thanks for contributing. There appear to be several changes unrelated to the title in your PR. Can you please rebase with |
|
Done! |
rwinch
added
in: web
Remove usage of comment and verison usage Signed-off-by: M-Faheem-Khan <[email protected]>
The test should not provide SavedCookie.class to the ObjectMapper since this is not done in production. In particular, it provides the type that it should be deserialized, but this must be provided in the JSON since the type is unknown at the time of deserialization. Issue gh-17006
rwinch
changed the title
|
Thanks for the PR @M-Faheem-Khan! I've rebased on main with some cleanup around your whitespace directly made to your commit. I've also added a commit that reverts the change to how the deserialization happens in SavedCookieMixinTests since this was incorrect. The build has been started and this PR will be merged into main as soon as it passes. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: gh-16889
Removing deprecated cookie methods comment & version.
These changes partly addresses the gh-16889. To prevent review fatigue, I'll create to additional PRs.
Note:
CookieMixinTestswill need to be updated when thecomment&versionmethods are removed from the Jakarta Servlet API. PR to deprecate the methods.