Skip to content

Start JDBC transactions only when there is an update #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ryanrupp
Copy link
Contributor

@ryanrupp ryanrupp commented Jan 22, 2025

Only start a new transaction if there's a delta for session updates with JDBC based repository

Avoids eagerly acquiring a connection or any other eager initialization that may happen alongside a transaction starting if there's no actual update to be made.

Solves #3329

…ith JDBC based repository

Avoids eagerly acquiring a connection or any other eager initialization that may happen alongside a transaction starting if there's no actual update to be made.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 22, 2025
@rwinch rwinch self-assigned this Apr 4, 2025
@rwinch rwinch added type: enhancement A general enhancement in: jdbc and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 4, 2025
@rwinch rwinch added this to the 3.5.0-RC1 milestone Apr 4, 2025
@rwinch rwinch enabled auto-merge (rebase) April 4, 2025 21:46
@rwinch rwinch closed this Apr 22, 2025
auto-merge was automatically disabled April 22, 2025 14:57

Pull request was closed

@rwinch rwinch reopened this Apr 22, 2025
@rwinch rwinch force-pushed the only-start-transaction-if-delta-for-jdbc branch from c07c5c0 to b516013 Compare April 22, 2025 15:32
@rwinch rwinch merged commit 40a8f55 into spring-projects:main Apr 22, 2025
4 checks passed
@rwinch
Copy link
Member

rwinch commented Apr 22, 2025

Thanks for the Pull Request! This is now merged into main 😄

@ryanrupp ryanrupp deleted the only-start-transaction-if-delta-for-jdbc branch April 22, 2025 16:13
@rwinch rwinch changed the title Only start a new transaction if there's a delta for session updates w… Optimize Starting Transactions Apr 22, 2025
@rwinch rwinch changed the title Optimize Starting Transactions Start JDBC transactions only when there is an update Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: jdbc type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants