[Fixes #1671] Passthrough dialect_kwargs to ops.create_foreign_key()
#1672
Conversation
…`postgresql_not_valid`
…oreign_key()` to enable `postgresql_not_valid`
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision f2eec75 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change f2eec75: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5985 |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision c702f25 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset c702f25 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5985 |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision bfcd8e4 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset bfcd8e4 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5985 |
|
@CaselIT it's unclear to me why these mssql tests might be failing, can you point me in the right direction here? https://jenkins.sqlalchemy.org/job/alembic_gerrit/pyv=py313,sqla=sqlamain/1452/#showFailuresLink |
|
that seems unrelated. @zzzeek did https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5964 break alembic? |
|
the fail here was fixed in main so if you rebase we can run again |
|
actually nm the fix was in sqlalhcemy so i can just re-run |
|
Michael Bayer (zzzeek) wrote: recheck View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5985 |
|
can you add a changelog file ? you can follow the format as seen in https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5873/12/docs/build/unreleased/1330.rst . the message here would be a lot shorter since this is a much simpler change. your "tags" would be "usecase, operations" |
@zzzeek added, thank you for the example to pattern match! |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 246a363 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 246a363 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5985 |
|
yes, we will take if from here, thanks! |
Description
Fixes #1671
SqlAlchemy supports adding dialect kwargs for foreign keys, as does
op.create_foreign_key(), but the renderer forops.CreateForeignKeyOpdoes not pass throughdialect_kwargs. An example of this ispostgresql_not_valid.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!