Absolute report path is treated like a relative path if it also exists within the current directory

[schmittjoh]

If you pass an absolute report path like this --report-checkstyle=/tmp/phpcs-results, this is still prefixed with the current directory.

In the 2.x versions, the current path is not prepended when it is absolute already.

[schmittjoh]

The 2.x versions seem also to be affected. Further debugging suggests that this error happens if you have a file named tmp in the current directory (and the passed report path also ends in tmp, see above).

I would suggest to check whether the path starts with a / and treat it as absolute in that case. Problematic code paths are here:

• 2.x version:

  PHP_CodeSniffer/CodeSniffer/CLI.php

  Line 774 in a71771e

  $dir = PHP_CodeSniffer::realpath(getcwd().'/'.$dir);

• 3.x version:

  PHP_CodeSniffer/src/Config.php

  Line 923 in e85ff8a

  $dir = Util\Common::realpath(getcwd().'/'.$dir);

[gsherwood]

I would suggest to check whether the path starts with a / and treat it as absolute in that case.

Sounds like a good plan to me.

[gsherwood]

Fixed now. Thanks for the report.