Javascript sniffer fails with function called "Function"

[gsouf]

Running php code sniffer on javascript file that has the function Function will detect it as the keyword function. See the example:

var a = Function('return 1+1');

Code fixer returns this error:

Expected 1 space after FUNCTION keyword; 0 found (Squiz.Functions.MultiLineFunctionDeclaration.SpaceAfterFunction)

But this line is actually correct and there is no fix needed

[gsherwood]

Just out of interest, do you actually define a function called Function or were you just looking for ways to trick the tokenizer? It would be nice to know if there is some real code that it had trouble parsing.

[gsherwood]

Thanks for the report. Still keen to know if the code is real or not.

[gsouf]

Hi @gsherwood yes the code is real, I'm using the javascript function Function in order to provide a way to send user defined functions from a php string to a phantomjs running webpage; https://github.com/gsouf/phantomphp/blob/master/src/phantom/page.handlers.js#L71

[gsouf]

Btw thanks for the fix, I will check soon

[gsherwood]

Hi @gsherwood yes the code is real

Thanks for confirming that. Please let me know if the fix doesn't work for you, although I did test the file you linked (minus the @codingStandardsIgnore comments) and confirmed the error is no longer shown.