Skip to content

SELF is not recognised as T_SELF token in: return new self #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michalbundyra opened this issue Dec 15, 2016 · 1 comment
Closed

SELF is not recognised as T_SELF token in: return new self #1245

michalbundyra opened this issue Dec 15, 2016 · 1 comment
Labels
Type: bug

Comments

@michalbundyra
Copy link
Contributor 

class MyClass {
  public static function getInstance() {
    return new self;
  }
}

In above, self is recognised as T_STRING token, not as T_SELF token.
michalbundyra added a commit to zendframework/zend-coding-standard that referenced this issue Dec 15, 2016
@michalbundyra
PHP\InstantiatingParenthesis fix for anonymous classes and furureproo…
154bf21 
…f approach for "new self"

- see issue squizlabs/PHP_CodeSniffer#1245
@gsherwood gsherwood changed the title "self" is not recognised as T_SELF token in "return new self" SELF is not recognised as T_SELF token in: return new self Dec 21, 2016
gsherwood added a commit that referenced this issue Dec 21, 2016
@gsherwood
Fixed bug #1245 : SELF is not recognised as T_SELF token in: return n…
79cd3dc 
…ew self
@gsherwood
Copy link
Member

I've fixed the tokenizer for this specific case. Thanks for the report.

jrfnl added a commit to jrfnl/PHPCompatibility that referenced this issue Dec 22, 2016
@jrfnl
Recognize T_SELF as well in variable variables.
6e043a2 
Fixes failing unit tests caused by changed behaviour of PHPCS > 2.7.1.
See:
* squizlabs/PHP_CodeSniffer@79cd3dc
* squizlabs/PHP_CodeSniffer#1245
@jrfnl jrfnl mentioned this issue Dec 22, 2016
Merged
@photodude photodude mentioned this issue Feb 15, 2017
Merged
@stof stof mentioned this issue Mar 2, 2017
Closed
jrfnl added a commit to PHPCSStandards/PHPCSUtils that referenced this issue May 17, 2024
@jrfnl
InlineNames::resolveSelf(): fix backward compatibility with PHPCS < 2…
b8f119c 
….8.0

In PHPCS < 2.8.0, the `self` in `return new self` would be tokenized as `T_STRING`, not `T_SELF`.

This commit adds a work-around to the utility method to handle the situation correctly.

Includes a unit test covering the issue.

Ref: squizlabs/PHP_CodeSniffer#1245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsherwood @michalbundyra