PEAR.WhiteSpace.ScopeClosingBrace can throw an error while fixing mixed PHP/HTML

[es02]

PHP Warning:  str_repeat(): Second argument has to be greater than or equal to 0 in /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/PEAR/Sniffs/WhiteSpace/ScopeClosingBraceSniff.php on line 181
PHP Stack trace:
PHP   1. {main}() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:182
PHP   4. PHP_CodeSniffer->processFiles() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:998
PHP   5. PHP_CodeSniffer->processFile() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:653
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1811
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:160
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:190
PHP  10. PEAR_Sniffs_WhiteSpace_ScopeClosingBraceSniff->process() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:576
PHP  11. str_repeat() /home/es02/.config/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/PEAR/Sniffs/WhiteSpace/ScopeClosingBraceSniff.php:181

Not sure what chunk of the ancient code I was running it against threw this though >.<

[gsherwood]

I typically can't figure these out unless you happen to have some code I can use to generate the error. Any chance you could run PHPCS again with the -v flag and see what file it was processing when the errors appeared? If possible, getting access to that file would let me replicate and fix the issue.

[gsherwood]

Closing due to lack of feedback. If you manage to find a code sample, please post it here and I'll look into it again.

[t-richards]

@gsherwood I've created a repo with a minimal(-ish) working example -- running phpcbf against it will reproduce this issue.

• Repository: https://github.com/t-richards/phpcs-pear-tester
• Source file: https://github.com/t-richards/phpcs-pear-tester/blob/master/src/mini-header.phtml
• Warning message: https://travis-ci.org/t-richards/phpcs-pear-tester/builds/226989975#L279

[gsherwood]

Thanks a lot for putting that together. I was able to replicate and fix the problem easily.