Save values (cli options) passed manually #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to save manually passed values in order to prevent using default values in PHP_CodeSniffer::process ($cliValues = $this->cli->getCommandLineValues())
ksimka
added a commit
to ksimka/PHP_CodeSniffer
that referenced
this pull request
Nov 18, 2013
We need to save manually passed values in order to prevent using default values in `PHP_CodeSniffer::process` (`$cliValues = $this->cli->getCommandLineValues()`) I'm not sure if this is acceptable, so I made simple changes in previous PR (squizlabs#172). Choose which one better reflects your vision of doing this.
|
I had always assumed you would pass in the entire array of values (as this PR also assumes) but I think your other PR is better because it is more flexible. So I'll close this one and merge that one. Thanks for providing a couple of options. |
TimWolla
pushed a commit
to TimWolla/PHP_CodeSniffer
that referenced
this pull request
Dec 28, 2023
…b_actions/actions/download-artifact-4 GH Actions: Bump actions/download-artifact from 3 to 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to save manually passed values in order to prevent using default values in
PHP_CodeSniffer::process($cliValues = $this->cli->getCommandLineValues())