Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

client http, support SSL insecure connections #120

Closed
mcuadros opened this issue Nov 9, 2016 · 2 comments
Closed

client http, support SSL insecure connections #120

mcuadros opened this issue Nov 9, 2016 · 2 comments
Milestone

Comments

@mcuadros
Copy link
Contributor

mcuadros commented Nov 9, 2016

As did @StupidHod we need to have optional support for insecure SSL connections:
StupidHod@ed21925#diff-8c989aecb091aec747030aaddeaee67aR29

@mcuadros mcuadros added this to the v4 milestone Nov 9, 2016
@mcuadros
Copy link
Contributor Author

mcuadros commented Nov 9, 2016

@ferhatelmas maybe you are interested on this

@ferhatelmas
Copy link
Contributor

@mcuadros Sure, I am interested and thanks for letting me know about it.

ferhatelmas added a commit to ferhatelmas/go-git that referenced this issue Nov 11, 2016
 * new http client factory ready to install/override default http(s)
 * mv GitUploadPackServiceFactory to clients.common pkg
 * rename http.HTTPError to http.Err
 * rename http.HTTPAuthMethod to http.AuthMethod
 * general improvements:
   - update install link in readme to v4 (example are already pointing v4)
   - fix indentation in package doc (styling for godoc.org)
   - use http.Status constants instead of integers
   - close leaked response body
   - rm named returns which stutter in doc
   - fix one format string
   - rm unnecessary if checks
   - documentation fixes
ferhatelmas added a commit to ferhatelmas/go-git that referenced this issue Nov 11, 2016
 * new http client factory ready to install/override default http(s)
 * mv GitUploadPackServiceFactory to clients.common pkg
 * rename http.HTTPError to http.Err
 * rename http.HTTPAuthMethod to http.AuthMethod
 * general improvements:
   - update install link in readme to v4 (example are already pointing v4)
   - fix indentation in package doc (styling for godoc.org)
   - use http.Status constants instead of integers
   - close leaked response body
   - rm named returns which stutter in doc
   - fix one format string
   - rm unnecessary if checks
   - documentation fixes
ferhatelmas added a commit to ferhatelmas/go-git that referenced this issue Nov 14, 2016
 * new http client factory ready to install/override default http(s)
 * mv GitUploadPackServiceFactory to clients.common pkg
 * rename http.HTTPError to http.Err
 * rename http.HTTPAuthMethod to http.AuthMethod
 * add doc and examples/ usage
 * general improvements:
   - update install link in readme to v4 (example are already pointing v4)
   - fix indentation in package doc (styling for godoc.org)
   - use http.Status constants instead of integers
   - close leaked response body
   - rm named returns which stutter in doc
   - fix one format string
   - rm unnecessary if checks
   - documentation fixes
mcuadros pushed a commit that referenced this issue Jan 31, 2017
* new http client factory ready to install/override default http(s)
 * mv GitUploadPackServiceFactory to clients.common pkg
 * rename http.HTTPError to http.Err
 * rename http.HTTPAuthMethod to http.AuthMethod
 * add doc and examples/ usage
 * general improvements:
   - update install link in readme to v4 (example are already pointing v4)
   - fix indentation in package doc (styling for godoc.org)
   - use http.Status constants instead of integers
   - close leaked response body
   - rm named returns which stutter in doc
   - fix one format string
   - rm unnecessary if checks
   - documentation fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants