Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

fix file mode handling #274

Closed
smola opened this issue Feb 17, 2017 · 1 comment
Closed

fix file mode handling #274

smola opened this issue Feb 17, 2017 · 1 comment
Labels
bug
Milestone
v4.0.0-rc10

Comments

@smola
Copy link
Collaborator

smola commented Feb 17, 2017

We are currently doing some incorrect normalization of FileMode when converting them to os.FileMode. We should preserve original filemodes, and have a custom comparison function that check for some legacy cases.
@smola smola added the bug label Feb 17, 2017
@smola smola modified the milestones: v4, v4.0.0-rc10 Feb 17, 2017
@alcortesm alcortesm mentioned this issue Mar 1, 2017
Merged
@smola smola closed this as completed in #297 Mar 3, 2017
smola added a commit that referenced this issue Mar 3, 2017
@smola
Merge pull request #297 from alcortesm/issue274
59335b6 
issue #274: new filemode package
@smola
Copy link
Collaborator Author

smola commented Mar 3, 2017

fixed by #297

@smola smola reopened this Mar 3, 2017
@smola smola closed this as completed Mar 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v4.0.0-rc10
Development

No branches or pull requests
1 participant
@smola