This repository was archived by the owner on Sep 11, 2020. It is now read-only.
ulreq: adds encoder and decoder for upload-request messages #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
suggested changes
Oct 31, 2016
| @@ -0,0 +1,542 @@ | |||
| package ulreq_test | |||
There was a problem hiding this comment.
can you remove _test we are not using this methodology
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* ulreq: adds encoder and decoder for upload-request messages * ulreq: stop using _test suffix for testing package names (@mcuadros comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds a new package:
upreqto handle upload-requests messages from a git-upload-pack service. You will find a description of the message here.The package introduces a new type for representing upload-requests messages in memory, an its encoder and a decoder.
The SSH client has been updated to use this new type and its encoder and the code for stepping through the pack protocol has been cleaned.