This repository was archived by the owner on Sep 11, 2020. It is now read-only.
new plumbing package #118
Merged
new plumbing package #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @smola |
smola
suggested changes
Nov 8, 2016
| "gopkg.in/src-d/go-git.v4/core" | ||
| "gopkg.in/src-d/go-git.v4/plumbing/clients" | ||
| "gopkg.in/src-d/go-git.v4/plumbing/clients/common" | ||
| "gopkg.in/src-d/go-git.v4/plumbing" |
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
* plumbing: now core was renamed to core, and formats and clients moved inside
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce a new plumbing package, this package contains all the core objects, and formats and clients packages. The goal is to introduce the logic division in git of plumbing and porcelain. All the package outside of the package plumbing are consider porcelain.
The main reason is because after think about where put the new
IndexStorer, I figure out, that the Index, Objects, clients are consider plumbing, and instead of having a cross reference between two package of same level ascoreandformats/index