This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport: create Client interface #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smola
commented
Nov 22, 2016
smola
commented
- plumbing: move plumbing/client package to plumbing/transport.
- a Client can instantiate any client transport service.
- InstallProtocol installs a Client for a given protocol, instead of just a UploadPackService.
- A Client can open a session for fetch-pack or send-pack for a specific Endpoint.
- Adapt ssh and http clients to the new client interface.
* A Client can instantiate any client transport service. * InstallProtocol installs a Client for a given protocol, instead of just a UploadPackService. * A Client can open a session for fetch-pack or send-pack for a specific Endpoint. * Adapt ssh and http clients to the new client interface.
alcortesm
suggested changes
Nov 23, 2016
| @@ -1,46 +1,114 @@ | |||
| // Package clients includes the implementation for different transport protocols | |||
There was a problem hiding this comment.
The name of the package has change from clients to transport.
There was a problem hiding this comment.
Updated docs, since they were outdated (not just the package name).
| @@ -1,46 +1,114 @@ | |||
| // Package clients includes the implementation for different transport protocols | |||
| // | |||
| // go-git needs the packfile and the refs of the repo. The | |||
There was a problem hiding this comment.
I think we should capitalize go-git here, as in man pages: https://groups.google.com/forum/#!topic/comp.os.plan9/lZ6kTwJfeAA
| type FetchPackSession interface { | ||
| Session | ||
| // AdvertisedReferences retrieves the advertised references for a | ||
| // repository. It must be called before Pack. |
There was a problem hiding this comment.
It must be called before Pack.
we should briefly explain why: is this because the protocol says so or because some internal limitation in our code?
There was a problem hiding this comment.
Done. Added further clarifications.
It SHOULD be called before FetchPack and it MUST NOT be called after FetchPack. This is to respect the protocol, so that one of our "Sessions" match a single git-fetch-pack execution.
alcortesm
approved these changes
Nov 23, 2016
mcuadros
pushed a commit
that referenced
this pull request
Nov 23, 2016
* plumbing: move plumbing/client package to plumbing/transport. * transport: create Client interface. * A Client can instantiate any client transport service. * InstallProtocol installs a Client for a given protocol, instead of just a UploadPackService. * A Client can open a session for fetch-pack or send-pack for a specific Endpoint. * Adapt ssh and http clients to the new client interface. * updated doc
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* plumbing: move plumbing/client package to plumbing/transport. * transport: create Client interface. * A Client can instantiate any client transport service. * InstallProtocol installs a Client for a given protocol, instead of just a UploadPackService. * A Client can open a session for fetch-pack or send-pack for a specific Endpoint. * Adapt ssh and http clients to the new client interface. * updated doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.