This repository was archived by the owner on Sep 11, 2020. It is now read-only.
storage: filesystem, clean close when the packfile is not used #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
suggested changes
Nov 28, 2016
| @@ -72,34 +78,58 @@ func (w *PackWriter) buildIndex() { | |||
| w.result <- err | |||
| } | |||
|
|
|||
| func (w *PackWriter) Write(p []byte) (n int, err error) { | |||
| // waitBuildIndex waits until buildIndex function finish, this can terminate | |||
| @@ -72,34 +78,58 @@ func (w *PackWriter) buildIndex() { | |||
| w.result <- err | |||
| } | |||
|
|
|||
| func (w *PackWriter) Write(p []byte) (n int, err error) { | |||
| // waitBuildIndex waits until buildIndex function finish, this can terminate | |||
| // with with a packfile.ErrEmptyPackfile, this means that nothing was written | |||
| return w.synced.Write(p) | ||
| } | ||
|
|
||
| // Close close all the file descriptors and save the final packfile, if nothing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to fix #126
If not fixed this problem directly, is a step towards.
When the PackWriter was created and not used, the temp file was keep. Also an error was returned because a empty packfile was read