This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport: add local transport #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smola
commented
Nov 28, 2016
smola
commented
- transport: move common packp protocol out of ssh transport.
- fixtures: add fixture for empty repository.
- transport: add local transport
- transport/client: add local handler for file://
Current coverage is 74.87% (diff: 30.35%)@@ master #145 diff @@
==========================================
Files 78 77 -1
Lines 5091 5007 -84
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 3838 3749 -89
- Misses 804 831 +27
+ Partials 449 427 -22
|
mcuadros
suggested changes
Nov 28, 2016
| DotGitHash: plumbing.NewHash("4abe340d8d378baf7c2bfb2854c0fa498642bac3"), | ||
| ObjectsCount: 0, | ||
| }, | ||
| } |
There was a problem hiding this comment.
closing } in the same line please
| @@ -21,7 +23,7 @@ func InstallProtocol(scheme string, c transport.Client) { | |||
| } | |||
|
|
|||
| // NewClient returns the appropriate client among of the set of known protocols: | |||
| // HTTP, SSH. See `InstallProtocol` to add or modify protocols. | |||
| // HTTP, SSH or local. See `InstallProtocol` to add or modify protocols. | |||
|
Updated PR with more docs about internal/common. |
mcuadros
approved these changes
Nov 29, 2016
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* transport: move common packp protocol out of ssh transport. * fixtures: add fixture for empty repository. * transport: add file:// transport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.