This repository was archived by the owner on Sep 11, 2020. It is now read-only.
protocol/packp: UploadPackResponse implementation #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
suggested changes
Dec 6, 2016
| import ( | ||
| "fmt" | ||
| "io" | ||
|
|
| import ( | ||
| "bytes" | ||
|
|
||
| . "gopkg.in/check.v1" |
| import ( | ||
| "errors" | ||
| "io" | ||
|
|
| import ( | ||
| "bytes" | ||
|
|
||
| . "gopkg.in/check.v1" |
| "gopkg.in/src-d/go-git.v4/plumbing" | ||
| ) | ||
|
|
||
| type ServerResponseSuite struct{} |
There was a problem hiding this comment.
You could add at least 1 test for unexpected flush and 1 test for malformed input.
| return r.r.Read(p) | ||
| } | ||
|
|
||
| // Close the underlying reading, if any |
| . "gopkg.in/check.v1" | ||
| ) | ||
|
|
||
| type UploadPackResponseSuite struct{} |
There was a problem hiding this comment.
You could add a test for malformed input.
| ) { | ||
| res := packp.NewUploadPackResponse(req) | ||
| if err := res.Decode(r); err != nil { | ||
| return nil, fmt.Errorf("error decondig upload-pack response: %s", err) |
| @@ -98,6 +98,32 @@ func (s *RemoteSuite) TestFetch(c *C) { | |||
| } | |||
| } | |||
|
|
|||
| func (s *RemoteSuite) TestFetchDeept(c *C) { | |||
There was a problem hiding this comment.
Deept -> Depth or Deept -> Deep
| "gopkg.in/src-d/go-git.v4/config" | ||
| "gopkg.in/src-d/go-git.v4/fixtures" | ||
| "gopkg.in/src-d/go-git.v4/plumbing" | ||
| "gopkg.in/src-d/go-git.v4/storage/memory" | ||
|
|
||
| "strings" | ||
|
|
Current coverage is 76.82% (diff: 88.34%)@@ master #161 diff @@
==========================================
Files 83 86 +3
Lines 5326 5407 +81
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4115 4154 +39
- Misses 754 805 +51
+ Partials 457 448 -9
|
smola
changed the title
smola
approved these changes
Dec 6, 2016
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
* plumbing/protocol: paktp avoid duplication of haves, wants and shallow * protocol/pakp: UploadPackResponse implementation * changes * changes * changes * debug * changes
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Display Golang version on build info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of
packp.UploadPackResponsebasically handles all the responses after call FetchPack, the messages handled areshallow-updateandserver-responseThe
packp.UploadPackResponseimplementsio.ReadCloserallowing to read the packfile directly from it.