This repository was archived by the owner on Sep 11, 2020. It is now read-only.
protocol/packp: add report status message. #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.64% (diff: 90.90%)@@ master #162 diff @@
==========================================
Files 83 85 +2
Lines 5330 5394 +64
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4117 4134 +17
- Misses 756 808 +52
+ Partials 457 452 -5
|
mcuadros
suggested changes
Dec 6, 2016
| } | ||
|
|
||
| if !flushed { | ||
| return fmt.Errorf("missing flush") |
There was a problem hiding this comment.
how can you reach this point without flushed being true? (with this code)
There was a problem hiding this comment.
when scan.Scan() = false in the first iteration.
mcuadros
approved these changes
Dec 6, 2016
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.