This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Extract billy #173
Merged
Extract billy #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.17% (diff: 100%)@@ master #173 diff @@
==========================================
Files 94 92 -2
Lines 6051 5793 -258
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4723 4471 -252
- Misses 839 857 +18
+ Partials 489 465 -24
|
Serabe
force-pushed
the
feature/extract-billy
branch
from
97c00da to
5268cca
Compare
smola
suggested changes
Dec 12, 2016
| @@ -4,7 +4,7 @@ import ( | |||
| "testing" | |||
|
|
|||
| "gopkg.in/src-d/go-git.v4/storage/test" | |||
| "gopkg.in/src-d/go-git.v4/utils/fs/os" | |||
| "srcd.works/go-billy.v0/os" | |||
There was a problem hiding this comment.
Now that it is an external library, it should go into the third import block.
There was a problem hiding this comment.
I've gone through all the changed files and added it to a third group. When needed, I've grouped other imports as well.
Thank you for the review!
Serabe
force-pushed
the
feature/extract-billy
branch
from
7a07e53 to
a7eae73
Compare
smola
suggested changes
Dec 12, 2016
| @@ -134,11 +134,11 @@ import ( | |||
| "io" | |||
|
|
|||
| "gopkg.in/src-d/go-git.v4" | |||
| "gopkg.in/src-d/go-git.v4/utils/fs" | |||
| "srcd.works/go-billy.v0/os" | |||
|
rebase? |
Serabe
force-pushed
the
feature/extract-billy
branch
2 times, most recently
from
bee7ae9 to
cb804a9
Compare
ajnavarro
approved these changes
Dec 14, 2016
mcuadros
suggested changes
Dec 14, 2016
| osfs "gopkg.in/src-d/go-git.v4/utils/fs/os" | ||
|
|
||
| "github.com/alcortesm/tgz" | ||
| "srcd.works/go-billy.v0" |
There was a problem hiding this comment.
please create a tag in go-bily and change the import to a version
Serabe
force-pushed
the
feature/extract-billy
branch
from
cb804a9 to
a591c46
Compare
|
@Serabe last rebase |
Billy is a new library directly extracted from go-git. It abstract several storages systems in a filesystem interface. More in github.com/src-d/billy
Serabe
force-pushed
the
feature/extract-billy
branch
from
a591c46 to
491ad2d
Compare
|
@mcuadros done. Waiting for CI. |
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* Extract billy Billy is a new library directly extracted from go-git. It abstract several storages systems in a filesystem interface. More in github.com/src-d/billy * Fix grouping in imports block * Update billy to v1 * Re-remove fs_implementation example
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Fixed typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Billy is a new library directly extracted from go-git. It abstract
several storages systems in a filesystem interface.
More in github.com/src-d/billy