This repository was archived by the owner on Sep 11, 2020. It is now read-only.
move plumbing from top level package to plumbing #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should merge this PR without squash. |
Current coverage is 76.61% (diff: 76.35%)@@ master #183 diff @@
==========================================
Files 92 92
Lines 5892 5913 +21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4594 4530 -64
- Misses 810 905 +95
+ Partials 488 478 -10
|
|
If you don't mind, can you include in this PR, rename some files in the root of the project to singular? |
ajnavarro
suggested changes
Dec 14, 2016
| @@ -9,13 +9,15 @@ import ( | |||
| "gopkg.in/src-d/go-git.v4/plumbing/transport/client" | |||
|
|
|||
| . "gopkg.in/check.v1" | |||
| "gopkg.in/src-d/go-git.v4/plumbing/storer" | |||
| @@ -163,7 +163,7 @@ func c_TreeWalker_Close(tw uint64) { | |||
| if !ok { | |||
| return | |||
| } | |||
| walker := obj.(*git.TreeIter) | |||
| walker := obj.(*object.TreeIter) | |||
| walker.Close() | |||
| } | |||
| */ | |||
There was a problem hiding this comment.
All this file is commented? maybe we can delete it in this refactor.
There was a problem hiding this comment.
Yep. cshared package is half-commented-half-broken until we stabilize the API.
| @@ -1418,7 +1419,7 @@ func (s *TreeSuite) TestTreeDecodeReadBug(c *C) { | |||
| }, | |||
| }, | |||
| Hash: plumbing.Hash{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, | |||
There was a problem hiding this comment.
ZeroHash? (maybe is not the correct PR to change it)
There was a problem hiding this comment.
Yep. Not touching it here.
| @@ -8,6 +8,7 @@ import ( | |||
| "gopkg.in/src-d/go-git.v4/plumbing" | |||
|
|
|||
| . "gopkg.in/check.v1" | |||
| "gopkg.in/src-d/go-git.v4/plumbing/object" | |||
|
@mcuadros Done. Except for references.go (which is for a function called References, which we might remove/move anyway) and options.go (which actually defines Options objects). |
* Object and its implementations now depend only on storer.EncodedObjectStorer, not git.Repository. * Tests are decoupled accordingly.
* move Object/Commit/File/Tag/Tree to plumbing/object. * move checkClose to utils/ioutil.
ajnavarro
approved these changes
Dec 14, 2016
|
fuck, I merged doing squash, sorry |
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* plumbing: rename Object -> EncodedObject. * plumbing/storer: rename ObjectStorer -> EncodedObjectStorer. * move difftree to plumbing/difftree. * move diff -> utils/diff * make Object/Tag/Blob/Tree/Commit/File depend on storer. * Object and its implementations now depend only on storer.EncodedObjectStorer, not git.Repository. * Tests are decoupled accordingly. * move Object/Commit/File/Tag/Tree to plumbing/object. * move Object/Commit/File/Tag/Tree to plumbing/object. * move checkClose to utils/ioutil. * move RevListObjects to plumbing/revlist.Objects. * move DiffTree to plumbing/difftree package. * rename files with plural nouns to singular * plumbing/object: add GetBlob/GetCommit/GetTag/GetTree.
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.