This repository was archived by the owner on Sep 11, 2020. It is now read-only.
packfile/scanner: reset zlib reader instead of new one #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.09% (diff: 63.63%)@@ master #201 diff @@
==========================================
Files 96 96
Lines 6224 6232 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4775 4742 -33
- Misses 923 971 +48
+ Partials 526 519 -7
|
smola
approved these changes
Jan 5, 2017
alcortesm
suggested changes
Jan 9, 2017
| @@ -275,19 +276,28 @@ func (s *Scanner) NextObject(w io.Writer) (written int64, crc32 uint32, err erro | |||
| // ReadRegularObject reads and write a non-deltified object | |||
| // from it zlib stream in an object entry in the packfile. | |||
| func (s *Scanner) copyObject(w io.Writer) (int64, error) { | |||
There was a problem hiding this comment.
The comment on this function starts with a wrong function name.
There was a problem hiding this comment.
I think this change is not related to this PR, Could fix this naming issue into another PR?
There was a problem hiding this comment.
Yes, please. Avoid unrelated changes here.
There was a problem hiding this comment.
Sure, change it on another PR.
| if s.zr == nil { | ||
| zr, err := zlib.NewReader(s.r) | ||
| if err != nil { | ||
| return -1, fmt.Errorf("zlib initialization error: %s", err) |
There was a problem hiding this comment.
Why are we returning -1, this is not C!
Scanner.NextObject first return argument is not used anywhere, it is safe to return 0 here instead.
There was a problem hiding this comment.
I was just replicating the previous behavior. I can change it.
smola
approved these changes
Jan 9, 2017
alcortesm
approved these changes
Jan 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.