This repository was archived by the owner on Sep 11, 2020. It is now read-only.
blame: make line types and its fields public so they can be actually used #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
approved these changes
Jan 18, 2017
Current coverage is 76.28% (diff: 100%)@@ master #213 diff @@
==========================================
Files 96 96
Lines 6299 6299
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4845 4805 -40
- Misses 922 971 +49
+ Partials 532 523 -9
|
smola
approved these changes
Jan 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #211 @olivierbeaulieu noticed the line type is not public, so it is not actually very useful.
This fix makes line and its members public so they can be actually used.