This repository was archived by the owner on Sep 11, 2020. It is now read-only.
fixtures: initialize fixtures into separated methods #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.28% (diff: 100%)@@ master #214 diff @@
==========================================
Files 96 96
Lines 6299 6299
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4845 4805 -40
- Misses 922 971 +49
+ Partials 532 523 -9
|
mcuadros
approved these changes
Jan 18, 2017
alcortesm
approved these changes
Jan 19, 2017
smola
reviewed
Jan 19, 2017
|
|
||
| func (s *Suite) SetUpSuite(c *check.C) { | ||
| // InitFixtures set the correct path to be able to access to the fixtures files | ||
| func InitFixtures() { |
There was a problem hiding this comment.
Probably Init and Clean would be better names since we're already in the fixtures packages (e.g. fixtures.Init())
smola
approved these changes
Jan 19, 2017
To be able to use fixtures with other test frameworks than go-check, we created two methods, one to set fixtures path correctly, and another to remove all the temporal data created when testing.
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
To be able to use fixtures with other test frameworks than go-check, we created two methods, one to set fixtures path correctly, and another to remove all the temporal data created when testing.
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to use fixtures with other test frameworks than go-check,
we created two methods, one to set fixtures path correctly, and
another to remove all the temporal data created when testing.