This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport/http: fix partial request with haves. Fix #216. #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
changed the title
alcortesm
approved these changes
Jan 24, 2017
ajnavarro
changed the title
ajnavarro
commented
Jan 24, 2017
| @@ -38,3 +38,8 @@ func (s *UploadPackSuite) TestAdvertisedReferencesNotExists(c *C) { | |||
| c.Assert(err, Equals, transport.ErrRepositoryNotFound) | |||
| c.Assert(r, IsNil) | |||
| } | |||
|
|
|||
| // TODO revList implementation is returning more objects than expected. | |||
There was a problem hiding this comment.
I opened an issue (#222) to fix this problem.
Current coverage is 76.25% (diff: 40.00%)@@ master #221 diff @@
==========================================
Files 96 96
Lines 6299 6300 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4845 4804 -41
- Misses 922 972 +50
+ Partials 532 524 -8
|
Fix #216 Using the http transport, now if we request a partial packfile, (using haves that aren't head ones) the response is not an empty packfile. Skip this test in server implementation. Revlist implementation is returning more objects than expected.
ajnavarro
changed the title
smola
suggested changes
Jan 24, 2017
| @@ -69,7 +69,7 @@ type UploadHaves struct { | |||
| } | |||
|
|
|||
| // Encode encodes the UploadHaves into the Writer. | |||
There was a problem hiding this comment.
Add documentation about what does the flush parameter and why.
| @@ -171,10 +171,13 @@ func uploadPackRequestToReader(req *packp.UploadPackRequest) (*bytes.Buffer, err | |||
| return nil, fmt.Errorf("sending upload-req message: %s", err) | |||
| } | |||
|
|
|||
| if err := req.UploadHaves.Encode(buf); err != nil { | |||
| if err := req.UploadHaves.Encode(buf, false); err != nil { | |||
There was a problem hiding this comment.
Here UploadRequest is adding a flush, but UploadHaves is not? This seems a partial fix, since it's still against the HTTP protocol as specified here: https://github.com/git/git/blob/4e59582ff70d299f5a88449891e78d15b4b3fabe/Documentation/technical/http-protocol.txt#L302
Let's be triple check this.
smola
approved these changes
Jan 24, 2017
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the http transport, now if we request a partial packfile, (using haves that aren't head ones) the response is not an empty packfile.
Skip this test in server implementation. Revlist is returning more objects than expected.