This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing/revlist: input as a slice of hashes instead of commits #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajnavarro
commented
Feb 27, 2017
ajnavarro
commented
- Now the input of the method Objects inside revlist package is a slice of hashes instead of commits. Hashes can be from Blobs, Trees and Commits objects.
- ObjectStorer now is used to obtain the object content using hashes slice.
- This PR fix Revlist implementation returns more objects than expected. #222. Now a test into upload_pack_test.go file is not skipped anymore.
- Remove code from remote.go and server.go that is not necessary.
ajnavarro
changed the title
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 77.03% 77.04% +0.01%
==========================================
Files 116 116
Lines 7902 7904 +2
==========================================
+ Hits 6087 6090 +3
- Misses 1161 1162 +1
+ Partials 654 652 -2
Continue to review full report at Codecov.
|
smola
suggested changes
Feb 27, 2017
plumbing/revlist/revlist.go
Outdated
| @@ -11,30 +12,56 @@ import ( | |||
| ) | |||
|
|
|||
| // Objects applies a complementary set. It gets all the hashes from all | |||
| // the reachable objects from the given commits. Ignore param are object hashes | |||
| // the reachable objects from the given objects. Ignore param are object hashes | |||
| // that we want to ignore on the result. It is a list because is | |||
There was a problem hiding this comment.
It is a list because is easier to interact with other porcelain elements, but internally it is converted to a map.
This comment is about the internal implementation and users do not care too much about this. Could you just remove this part?
- Now the input of the method Objects inside revlist package is a slice of hashes instead of commits. Hashes can be from Blobs, Trees and Commits objects. - ObjectStorer now is used to obtain the object content using hashes slice. - This PR fix #222. Now a test into upload_pack_test.go file is not skipped anymore. - Remove code from remote.go and server.go that is not necessary.
alcortesm
approved these changes
Feb 28, 2017
smola
approved these changes
Feb 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.