This repository was archived by the owner on Sep 11, 2020. It is now read-only.
difftree: simplify hash comparison with deprecated files modes #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Difftree hash comparisson was quite complex because the hashes of deprecated files were diferent from the hashes of regular files. But git's difftree really treat them as equal. This patch fix this by making treenoder return the same hash for regular files than for deprecated files; now the hash comparison function is just a bytes.Equal call.
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 77.22% 77.19% -0.04%
==========================================
Files 117 117
Lines 7948 7937 -11
==========================================
- Hits 6138 6127 -11
Misses 1159 1159
Partials 651 651
Continue to review full report at Codecov.
|
ajnavarro
approved these changes
Mar 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difftree hash comparisson was quite complex because the hashes of
deprecated files were diferent from the hashes of regular files. But
git's difftree really treat these kind of files as equal.
This patch fix this by making treenoder generate the hash for deprecated
files as if they were regular files. This means the difftree hash comparison
function is now just a call to bytes.Equal.