This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport: make Endpoint an interface, fixes #362 #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smola
commented
Apr 27, 2017
smola
commented
- add internal *url.URL implementation for regular URLs.
- add internal implementation for SCP-like URLs.
alcortesm
suggested changes
Apr 27, 2017
plumbing/transport/common.go
Outdated
| User() string | ||
| // Password returns the password or an empty string if none is given. | ||
| Password() string | ||
| // User returns the user or an empty string if none is given. |
plumbing/transport/common.go
Outdated
| scpLikeUrlRegExp = regexp.MustCompile("^(?:(?P<user>[^@]+)@)?(?P<host>[^:]+):/?(?P<path>.+)$") | ||
| ) | ||
|
|
||
| func parseSCPLike(endpoint string) Endpoint { |
There was a problem hiding this comment.
Returning (Endpoint, bool) would be more idiomatic, so it can be used like:
path := "foo/bar"
if e, ok := parseSCPLike(path) ; ok {
return e, nil
}
// try other formats...
ajnavarro
approved these changes
Apr 27, 2017
* add internal *url.URL implementation for regular URLs. * add internal implementation for SCP-like URLs.
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 77.28% 76.71% -0.57%
==========================================
Files 122 122
Lines 8518 8555 +37
==========================================
- Hits 6583 6563 -20
- Misses 1198 1268 +70
+ Partials 737 724 -13
Continue to review full report at Codecov.
|
alcortesm
approved these changes
Apr 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.