Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

worktree: symlink support #436

Merged
merged 2 commits into from
Jun 19, 2017
Merged

worktree: symlink support #436

merged 2 commits into from
Jun 19, 2017

Conversation

mcuadros
Copy link
Contributor

Fixes: #358

@mcuadros mcuadros requested review from ajnavarro and alcortesm June 19, 2017 07:54
worktree.go Outdated
if err != nil {
return err
}
defer from.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing the close error.

worktree.go Outdated
if err != nil {
return err
}
defer from.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing the close error.

@codecov
Copy link

codecov bot commented Jun 19, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@3ae5d4d). Click here to learn what that means.
The diff coverage is 69.86%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #436   +/-   ##
========================================
  Coverage          ?   77.1%           
========================================
  Files             ?     124           
  Lines             ?    9084           
  Branches          ?       0           
========================================
  Hits              ?    7004           
  Misses            ?    1310           
  Partials          ?     770
Impacted Files Coverage Δ
utils/merkletrie/filesystem/node.go 65.43% <65.21%> (ø)
worktree_commit.go 69.78% <66.66%> (ø)
worktree.go 64.49% <73.33%> (ø)
worktree_status.go 69.47% <76.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae5d4d...ada10c2. Read the comment docs.

@mcuadros mcuadros merged commit 8b17cf0 into src-d:master Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants