This repository was archived by the owner on Sep 11, 2020. It is now read-only.
improve delete support on push #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
suggested changes
Jul 10, 2017
remote.go
Outdated
| var NoErrAlreadyUpToDate = errors.New("already up-to-date") | ||
| var ( | ||
| NoErrAlreadyUpToDate = errors.New("already up-to-date") | ||
| ErrServerDoesNotSupportDelete = errors.New("server does not support delete") |
There was a problem hiding this comment.
ErrDeleteRefNotSupported = errors.New("server does not support delete-refs")
* server: implement delete-refs and announce it. * remote: check if server announced delete-refs before trying to delete and fail fast if it does not. Note that the client does not need no send 'delete-refs' back to the server to be able to delete references: ``` delete-refs ----------- If the server sends back the 'delete-refs' capability, it means that it is capable of accepting a zero-id value as the target value of a reference update. It is not sent back by the client, it simply informs the client that it can be sent zero-id values to delete references. ``` So our server implementation does not check if the client sent delete-refs back, it just accepts deletes if it receives them.
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 78.07% 77.48% -0.59%
==========================================
Files 127 127
Lines 9268 9270 +2
==========================================
- Hits 7236 7183 -53
- Misses 1244 1311 +67
+ Partials 788 776 -12
Continue to review full report at Codecov.
|
|
Updated the PR, since my initial approach was not fully working. @ajnavarro is now verifying this in EDIT: Verified 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to delete and fail fast if it does not.
Note that the client does not need no send 'delete-refs' back
to the server to be able to delete references:
So our server implementation does not check if the client sent
delete-refs back, it just accepts deletes if it receives them.