This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Add AuthMethod based on HTTP Authorization header #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #504 +/- ##
==========================================
- Coverage 78.12% 77.42% -0.71%
==========================================
Files 127 127
Lines 9313 9323 +10
==========================================
- Hits 7276 7218 -58
- Misses 1241 1324 +83
+ Partials 796 781 -15
Continue to review full report at Codecov.
|
|
@strin looks like your PRs are being mixed because you are using the same branch, can you take care of this? |
mcuadros
suggested changes
Jul 25, 2017
| return | ||
| } | ||
|
|
||
| r.Header.Set("Authorization", a.token) |
There was a problem hiding this comment.
To be Bearer requires the format: " Authorization: Bearer %s"
| } | ||
|
|
||
| // NewTokenAuth returns a tokenAuth on the given authrorization token. | ||
| func NewTokenAuth(token string) *TokenAuth { |
There was a problem hiding this comment.
Can be called it NewBearerAuth ?
| } | ||
|
|
||
| func (a *TokenAuth) String() string { | ||
| return fmt.Sprintf("%s...", a.token[:10]) |
There was a problem hiding this comment.
The token should be cloaked, otherwise the security can be compromised.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
Authorization: Bearer XXXXXto authenticate Git HTTP requests.