This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Normalize filenames before comparing. #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some multibyte characters can have multiple representations. Before comparing strings, we need to normalize them. In this case we're normalizing to normalized form C, but it shouldn't matter as long as both strings are normalized to the same form. Fixes #495
|
Can you add some tests? Also maybe can we use norm only for Darwin? |
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 78.12% 77.62% -0.51%
==========================================
Files 129 130 +1
Lines 9746 9710 -36
==========================================
- Hits 7614 7537 -77
- Misses 1304 1360 +56
+ Partials 828 813 -15
Continue to review full report at Codecov.
|
|
@joshbetz I just updated your PR with a proper tests, I understand that is hard to do testing, since is a complex project. Thanks a lot for your PR, as soon as the CI, this PR will be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some multibyte characters can have multiple representations. Before
comparing strings, we need to normalize them. In this case we're
normalizing to normalized form C, but it shouldn't matter as long as
both strings are normalized to the same form.
Fixes #495