Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

packfile: use buffer pool for diffs #631

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

strib
Copy link
Contributor

@strib strib commented Oct 30, 2017

This reuses memory slightly more efficiently, and bufPool already exists so might as well use it here.

@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #631 into master will decrease coverage by 0.55%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   78.28%   77.72%   -0.56%     
==========================================
  Files         130      130              
  Lines       10221    10229       +8     
==========================================
- Hits         8001     7950      -51     
- Misses       1358     1430      +72     
+ Partials      862      849      -13
Impacted Files Coverage Δ
plumbing/format/packfile/diff_delta.go 91.15% <100%> (+0.67%) ⬆️
plumbing/transport/ssh/common.go 20.54% <0%> (-45.21%) ⬇️
plumbing/transport/ssh/auth_method.go 31.57% <0%> (-22.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50732e3...bcc296e. Read the comment docs.

@mcuadros mcuadros merged commit f98cab3 into src-d:master Oct 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants