This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Decode tree bug: incomplete reads break the decoding process #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 65.48% (diff: 0.00%)@@ master #64 diff @@
==========================================
Files 45 45
Lines 2530 2529 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1657 1656 -1
Misses 698 698
Partials 175 175
|
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* Add test that fails for incomplete reads from an object * Fix imcomplete reads
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the implementation of Tree.Decode, when reading the hash from the object, we are
not checking the return value of read.
When read reads less bytes than what we asked for (a not very common event), decoding the object fails.
This patch adds a test to force the situation (through a mock Object reader) and a fix.