Skip to content

ShellStream: Write skips a byte when buffer is full #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2017

Conversation

JasonQG
Copy link
Contributor

@JasonQG JasonQG commented Apr 20, 2017

Fix every 1025th byte being skipped

Fix every 1025th byte being skipped
@JasonQG JasonQG changed the title Update ShellStream.cs Fix bytes sent being skipped Apr 20, 2017
@JasonQG
Copy link
Contributor Author

JasonQG commented Aug 28, 2017

Any chance this could be included in the next release?

@drieseng drieseng added this to the 2016.1.0-beta3 milestone Sep 9, 2017
@drieseng
Copy link
Member

drieseng commented Sep 9, 2017

I'll merge this once I had time to add a regression test.

@drieseng drieseng self-assigned this Sep 17, 2017
@drieseng drieseng merged commit 985e3f3 into sshnet:develop Sep 17, 2017
@drieseng
Copy link
Member

I'll be adding tests later today.

@drieseng drieseng changed the title Fix bytes sent being skipped ShellStream: Write skips a byte when buffer is full Sep 17, 2017
drieseng added a commit that referenced this pull request Sep 17, 2017
Fixes issue #303.

Added tests for issue #303 and PR #211.
@drieseng
Copy link
Member

I've just released version 2016.1.0-beta3 of SSH.NET, which includes a fix for this issue.
Please use either the source, binary or NuGet distribution to confirm this version resolves the reported problem for you.

@JasonQG
Copy link
Contributor Author

JasonQG commented Oct 18, 2017

Sorry for the delay in responding. Tested with the beta, and it looks good. Thanks!

@JasonQG JasonQG deleted the patch-1 branch September 7, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants