Skip to content

993 progress: convert last 4 files outside of extensions/ #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 20, 2025

Conversation

teks
Copy link
Contributor

@teks teks commented Feb 19, 2025

Related Issue(s): #993

Description: Another round of conversion to pytest. In test_common_metadata.py, I assumed the several calls to self.item.clone() were unneeded because the original object was never used.

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (6d0bf65) to head (a9fdde3).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          54       54           
  Lines        7571     7571           
  Branches      922      922           
=======================================
  Hits         6927     6927           
  Misses        457      457           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good, appreciate this...the tests read much cleaner, at least to my eye, with these changes.

@gadomski gadomski added this pull request to the merge queue Feb 20, 2025
Merged via the queue into stac-utils:main with commit ff453bb Feb 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants