-
Notifications
You must be signed in to change notification settings - Fork 123
993 progress: convert last 4 files outside of extensions/ #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 54 54
Lines 7571 7571
Branches 922 922
=======================================
Hits 6927 6927
Misses 457 457
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking good, appreciate this...the tests read much cleaner, at least to my eye, with these changes.
Related Issue(s): #993
Description: Another round of conversion to pytest. In
test_common_metadata.py
, I assumed the several calls toself.item.clone()
were unneeded because the original object was never used.PR Checklist:
pre-commit run --all-files
)pytest
)Documentation has been updated to reflect changes, if applicableor improvesoverall codebase code coverage.Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.