Skip to content

Projection extension: migrate Assets on Items #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

bmcandr
Copy link
Contributor

@bmcandr bmcandr commented Apr 14, 2025

Related Issue(s):

Description:

  • Update the Projection extension's migrate method to migrate projection fields on Assets on Items and Item-Assets on Collections.
  • Rename test_migrate to test_migrate_item and add test_migrate_collection_item_assets

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski mentioned this pull request Apr 15, 2025
5 tasks
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (e713adf) to head (2f308dc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   91.62%   92.41%   +0.79%     
==========================================
  Files          54       55       +1     
  Lines        7578     8364     +786     
  Branches      923      963      +40     
==========================================
+ Hits         6943     7730     +787     
+ Misses        451      449       -2     
- Partials      184      185       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gadomski
Copy link
Member

Tight! Thanks for the bugfix!

@gadomski gadomski linked an issue Apr 15, 2025 that may be closed by this pull request
@gadomski gadomski added this pull request to the merge queue Apr 15, 2025
Merged via the queue into stac-utils:main with commit 897f3cb Apr 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projection extension's migrate method doesn't migrate Item's Assets
2 participants