Skip to content

Support STAC items without bbox #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

vprivat-ads
Copy link
Contributor

STAC items are not required to have a bbox, the field is prohibited for items having no geometry.

This PR allows to validate an API that returs such items.

Otherwise you face this error:

      Traceback (most recent call last):
        File "/home/vprivat/projects/env/lib/python3.12/site-packages/behave/model.py", line 1909, in run
          match.run(runner.context)
        File "/home/vprivat/projects/env/lib/python3.12/site-packages/behave/matchers.py", line 104, in run
          self.func(context, *args, **kwargs)
        File "features/steps/stac.py", line 158, in step_check_stac_api
          (warnings, errors) = validate_api(
                               ^^^^^^^^^^^^^
        File "/home/vprivat/projects/env/lib/python3.12/site-packages/stac_api_validator/validations.py", line 673, in validate_api
          validate_item_search(
        File "/home/vprivat/projects/env/lib/python3.12/site-packages/stac_api_validator/validations.py", line 1427, in validate_item_search
          validate_item_search_ids_does_not_override_all_other_params(
        File "/home/vprivat/projects/env/lib/python3.12/site-packages/stac_api_validator/validations.py", line 3343, in validate_item_search_ids_does_not_override_all_other_params
          _validate_search_ids_with_ids_no_override(
        File "/home/vprivat/projects/env/lib/python3.12/site-packages/stac_api_validator/validations.py", line 3238, in _validate_search_ids_with_ids_no_override
          bbox = item["bbox"]
                 ~~~~^^^^^^^^
      KeyError: 'bbox'

@gadomski gadomski merged commit 4bf2b10 into stac-utils:main Mar 25, 2025
8 checks passed
@vprivat-ads vprivat-ads deleted the allow-no-bbox branch March 25, 2025 13:53
@vprivat-ads
Copy link
Contributor Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants