Skip to content

Implement Filter Extension #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2022
Merged

Implement Filter Extension #100

merged 9 commits into from
May 9, 2022

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented May 4, 2022

Related Issue(s):

Description:

  • Implements Filter Extension as GET with CQL2-Text and POST with CQL2-JSON, supporting the Basic CQL2 and Basic Spatial Operators conformance classes.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the changelog

@philvarner philvarner requested review from jonhealy1 and gadomski and removed request for jonhealy1 May 9, 2022 18:00
@philvarner philvarner marked this pull request as ready for review May 9, 2022 18:00
@philvarner philvarner requested a review from jonhealy1 May 9, 2022 18:09
@philvarner philvarner changed the title Pv/filter extension Implement Filter Extension May 9, 2022
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does seem like stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/extensions/filter.py is general enough to (eventually) pull out to its own thing if/when that makes sense?

@philvarner
Copy link
Collaborator Author

I see the long-term plan is to rewrite this simple implementation using the pygeofilter AST. I didn't realize their implementation was that complete and composable until I went to use the text->json conversion methods.

@philvarner philvarner merged commit 9aabbe0 into main May 9, 2022
@philvarner philvarner deleted the pv/filter-extension branch May 9, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants