Skip to content

remove mongodb related code #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 23, 2022
Merged

remove mongodb related code #20

merged 8 commits into from
Feb 23, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): n/a

Description:

Remove mongodb related code.

@philvarner philvarner requested a review from jonhealy1 February 22, 2022 21:08
@jonhealy1
Copy link
Collaborator

jonhealy1 commented Feb 22, 2022 •
edited
Loading

@philvarner Looks good I think. It should pass if you run pre-commit run --all-files We might want to remove the push to pypi and test-pypi github actions too. It automatically pushes a new version to test-pypi on push to dev and a new version to pypi on a push to main.

@jonhealy1
Copy link
Collaborator

We could probably rename the dockerfile to just 'dockerfile' and the same with 'docker-compose.yml' as well

jonhealy1
jonhealy1 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@philvarner philvarner merged commit b5d59a6 into main Feb 23, 2022
@philvarner philvarner deleted the pv/remove-mongo branch February 23, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @jonhealy1