Clean up transactions logic #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
reviewed
Mar 1, 2022
| ).create_links() | ||
| stac_data["links"] = item_links | ||
|
|
||
| # elasticsearch doesn't like the fact that some values are float and some were int |
There was a problem hiding this comment.
I'm going to fix this in #31 -- I'm about to merge the stac-server issue about the same thing, so it should be straightforward to port it.
philvarner
reviewed
Mar 1, 2022
stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/serializers.py
Outdated
Show resolved
Hide resolved
philvarner
approved these changes
Mar 1, 2022
…ers.py Co-authored-by: Phil Varner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Cleaning up and simplifying the transactions logic
PR Checklist:
pre-commit run --all-files)make test)make docs)