Fix tests in test_item.py etc

[jonhealy1]

Related Issue(s):

• Re-enable numerous skipped tests #51
• if there are no collections, endpoint should return an object with an empty collections array, rather than 404 #64

Description:

Fix tests that should be working in test_item.py

PR Checklist:

• Code is formatted and linted (run pre-commit run --all-files)
• Tests pass (run make test)
• Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
• Changes are added to the changelog

[jonhealy1]

A lot of warnings

73 passed, 19 skipped, 273 warnings in 66.25s (0:01:06)

[philvarner]

I'm fine with merging this, but I think the need for the sleeps are a symptom of something else. My understanding with ES is that a client connected to the same node in a cluster (and in this case, we have a cluster of 1 node) is supposed to be able to insert/update an item and then retrieve the same item, so the fact that we're writing then having to wait to read seems like we're not writing correctly. I'll look into this in the next few days.

Another thing that would help is having a consistent setup/teardown -- a lot of these tests are running the same setup and teardown, so it's a lot of duplicated code.

[jonhealy1]

@philvarner True - maybe we aren't writing to the db correctly. I think I added delete statements in so many tests because so many tests were failing before saying this or that item already exists - I am going to try taking them out and see what happens now.

[jonhealy1]

The tests are inconsistent after deleting the delete statements - the tests will pass and then the next time a test will fail and the next time a few tests will fail then they will pass again - maybe there's a delay between sending the delete command and when the item is fully deleted?