move classes in transactions.py to core.py, to align with parent class organization #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2022 09:34
philvarner
commented
Mar 21, 2022
README.md
Outdated
|
|
||
| ```shell | ||
| cd stac_fastapi/elasticsearch | ||
| pip install -e .[dev] |
There was a problem hiding this comment.
this command was missing the -e, so changes to the code weren't reflected in the IDE.
philvarner
commented
Mar 21, 2022
| @@ -6,6 +6,7 @@ | |||
| desc = f.read() | |||
|
|
|||
| install_requires = [ | |||
| "fastapi", | |||
There was a problem hiding this comment.
this was used explicitly in one of the classes, but wasn't declared as a dependency (it's transitive from stac_fastapi)
philvarner
commented
Mar 21, 2022
|
|
||
|
|
||
| @attr.s | ||
| class TransactionsClient(BaseTransactionsClient): |
There was a problem hiding this comment.
no changes to these classes other than fixing up references and using datetime_type rather than datetime
Co-authored-by: Pete Gadomski <[email protected]>
gadomski
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
move classes in transactions.py to core.py, to align with parent class organization
PR Checklist:
pre-commit run --all-files)make test)make docs)