refactor tests suite in order to run it locally outside docker #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 22, 2024
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] |
vincentsarago
commented
Apr 22, 2024
| --log-driver none | ||
| ports: | ||
| # Maps tcp port 5432 on service container to the host | ||
| - 5432:5432 |
There was a problem hiding this comment.
we don't need this external service when using postgres pytest fixture
vincentsarago
commented
Apr 22, 2024
| @@ -16,6 +18,6 @@ WORKDIR /app | |||
|
|
|||
| COPY . /app | |||
|
|
|||
| RUN pip install -e .[dev,server] | |||
| RUN python -m pip install -e .[server] | |||
There was a problem hiding this comment.
This image is now used only for the server part. we'll use another image for testing (make test)
vincentsarago
commented
Apr 22, 2024
| postgres_host_writer=database.host, | ||
| postgres_port=database.port, | ||
| postgres_dbname=database.dbname, | ||
| testing=True, |
There was a problem hiding this comment.
testing=True could be removed because we are setting the dbname in the settings
vincentsarago
commented
Apr 22, 2024
| version = migrator.run_migration() | ||
| assert version | ||
|
|
||
| yield jan |
There was a problem hiding this comment.
This is the database fixture
vincentsarago
commented
Apr 22, 2024
| @@ -3,18 +3,18 @@ repos: | |||
| rev: 5.12.0 | |||
| hooks: | |||
| - id: isort | |||
| language_version: python3.8 | |||
| language_version: python | |||
There was a problem hiding this comment.
this change enables to run pre-commit on other python version
vincentsarago
force-pushed
the
feature/refactor-tests-suite
branch
from
96c3736 to
410421f
Compare
jonhealy1
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a refactor of the test suite, moving from local database to pytest fixture.
This is to ensure we don't touch the local postgres which may run on the user's computer.
This PR also aims to speed up the CI (avoiding building and user docker image)
FYI:
make testis still working for people who want to run tests in Docker but now you can also simply runpython -m pytest -s -vv(if you have postgres installed locally)