Support creating ItemCollections in Transaction Extension #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image copies the root project to /app and matching that through docker-compose allows host file updates to be copied without rebuilding the image.
Updates to the transaction spec indicate POST against items should allow ItemCollection.
In the transaction extension, Items and Collection can't have mismatched ids from the path, but should have the path collection id applied if it is missing. Ids for both are also not allowed to be a "percent encoded" value per RFC 3986.
|
Note: This is draft until stac-utils/stac-fastapi#574 is released, as tests here will fail without it. |
…d/stac-fastapi-pgstac into mjm/trasaction-item-collection
gadomski
requested changes
May 15, 2023
gadomski
reviewed
May 15, 2023
The spec leaves the return type for Item creation open to the implementation. This change unifies the response of both Item/ItemCollection POST requests to return an empty response with a Location header for the newly created single Item, in that case.
Use a setting value instead of a constant so that IDs could be set per instance.
gadomski
approved these changes
May 15, 2023
After realizing the extent of the breaking change resulting from a unified response between Item/ItemCollection Tx endpoint, restoring the original behavior.
|
@gadomski I added some commits that should address your comments, thanks for the feedback. I had started down the path of response unification, but then realized the extent to which it was a meaningful breaking changed, and walked it back in a subsequent commit. Tests pass locally against stac-fastapi |
gadomski
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements "create ItemCollection" via the Transaction extension and provides additional validation and behavior on ids when creating Items or ItemCollections. I'll note that the api spec indicates percent encoded characters are discouraged, but this change makes them invalid for this backend. That's an opinioned change, and I'm willing to walk it back to a subset (like just "/") if that flexibility is desired.
See: https://github.com/radiantearth/stac-spec/blob/master/best-practices.md#item-ids
See: https://github.com/radiantearth/stac-api-spec/blob/master/ogcapi-features/extensions/transaction/README.md#methods
Fixes: #23
PR Checklist:
pre-commithooks pass locallymake test)make docs)