Update item transactions in SQLAlchemy #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change primary key of items table
lossyrob
requested changes
Nov 30, 2021
stac_fastapi/sqlalchemy/stac_fastapi/sqlalchemy/transactions.py
Outdated
Show resolved
Hide resolved
I will write some tests |
|
@lossyrob Thanks for the feedback - I think the tests are good ... and everything is good now |
moradology
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
I've gone through the changes here and they look good to me - @lossyrob were there any amendments you had in mind?
geospatial-jeff
approved these changes
Dec 8, 2021
geospatial-jeff
approved these changes
Dec 9, 2021
lossyrob
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #302
Description:
Different collections can have items with the same ids. To delete or update an item, a collection should be specified. In core.py for sqlalchemy, get_item was recently changed so that only an item from the right collection is returned. This is a similar idea.
PR Checklist:
pre-commit run --all-files)make test)make docs)