Skip to content

Fix joplin pgstac #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2022
Merged

Conversation

remicres
Copy link
Contributor

@remicres remicres commented Jul 1, 2022

Related Issue(s):

Small fixes in stac-fastapi (with pgstac) joplin example

Description:

This PR addresses small fixes in the joplin example with pgstac.

  • wrong database port mapping (or I just have missed something here?)
  • bump pgstac image version
  • useless environment variables removed from the loadjoplin-pgstac container (for a newbie like me, discovering STAC, it is quite confusing to see those database related settings on this side)

I didn't try the SQLAlchemy example, but it might need the same corrections maybe.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a direct result of the changes in this PR, but in order to get this to launch successfully I had to increase the timeout setting in wait-for-it.sh to at least 30 seconds (from the default of 15).

loadjoplin-pgstac:
    image: stac-utils/stac-fastapi
    environment:
      - ENVIRONMENT=development
    volumes:
      - ./stac_fastapi:/app/stac_fastapi
      - ./scripts:/app/scripts
    command:
      - "./scripts/wait-for-it.sh"
      - "-t"
      - "30"
      - "app-pgstac:8082"
      - "--"
      - "python"
      - "/app/scripts/ingest_joplin.py"
      - "http://app-pgstac:8082"
    depends_on:
      - app-pgstac

@geospatial-jeff
Copy link
Collaborator

Confirmed this is all working with docker-compose up

@geospatial-jeff geospatial-jeff self-requested a review August 1, 2022 21:29
@geospatial-jeff geospatial-jeff merged commit fa658f7 into stac-utils:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants