Skip to content

Fix item bbox field validation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022
Merged

Fix item bbox field validation #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stac_pydantic/item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Dict, List, Optional, Union

from geojson_pydantic.features import Feature, FeatureCollection
from pydantic import AnyUrl, Field, constr, validator
from pydantic import AnyUrl, Field, constr, root_validator, validator
from pydantic.datetime_parse import parse_datetime

from stac_pydantic.api.extensions.context import ContextExtension
Expand Down Expand Up @@ -56,11 +56,11 @@ def to_dict(self, **kwargs):
def to_json(self, **kwargs):
return self.json(by_alias=True, exclude_unset=True, **kwargs)

@validator("bbox")
def validate_bbox(cls, v, values):
if v is None and not values.get("geometry"):
@root_validator(pre=True)
def validate_bbox(cls, values):
if values.get("geometry") and values.get("bbox") is None:
raise ValueError("bbox is required if geometry is not null")
return v
return values


class ItemCollection(FeatureCollection):
Expand Down