Skip to content

Permit None value for datetime #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Permit None value for datetime #116

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c14a00
Permit None value for datetime
alukach Jul 21, 2022
006b0cf
Update item.py
alukach Jul 21, 2022
a899217
Fix bug where `start_datetime` or `end_datetime` may not exist.
alukach Aug 29, 2022
fcbf19b
Rm unused import
alukach Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions stac_pydantic/item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

from geojson_pydantic.features import Feature, FeatureCollection # type: ignore
from pydantic import AnyUrl, Field, root_validator, validator
from pydantic.datetime_parse import parse_datetime

from stac_pydantic.api.extensions.context import ContextExtension
from stac_pydantic.links import Links
Expand All @@ -16,19 +15,16 @@ class ItemProperties(StacCommonMetadata):
https://github.com/radiantearth/stac-spec/blob/v1.0.0/item-spec/item-spec.md#properties-object
"""

datetime: Union[dt, str] = Field(..., alias="datetime")
datetime: Optional[dt] = Field(..., alias="datetime")

@validator("datetime")
def validate_datetime(cls, v: Union[dt, str], values: Dict[str, Any]) -> dt:
if v == "null":
if not values["start_datetime"] and not values["end_datetime"]:
def validate_datetime(cls, v: Optional[dt], values: Dict[str, Any]) -> Optional[dt]:
if v is None:
if not all([values.get("start_datetime"), values.get("end_datetime")]):
raise ValueError(
"start_datetime and end_datetime must be specified when datetime is null"
)

if isinstance(v, str):
return parse_datetime(v)

return v

class Config:
Expand Down