Skip to content

set start/end datetime to the unique datetime passed in api.Search #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2024
Merged

set start/end datetime to the unique datetime passed in api.Search #152

merged 3 commits into from
May 21, 2024

Conversation

vincentsarago
Copy link
Member

closes #79
closes #145

vincentsarago
vincentsarago commented May 21, 2024
View reviewed changes
stac_pydantic/api/search.py
if len(values) == 1:
values.insert(0, None)
values = [values[0], values[0]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went for a more verbose way (ref: #135 (review))

@vincentsarago vincentsarago merged commit dbc471e into main May 21, 2024
5 checks passed
@vincentsarago vincentsarago deleted the patch/start-end-datetime-when-single-datetime branch May 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

@philvarner philvarner Awaiting requested review from philvarner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search start_date property does not support single-value for datetime Search datetime parameter has incorrect semantics for instant
2 participants
@vincentsarago @gadomski