fix: editor ignoring changes

[Nemikolh]

This PR fixes a bug reported by @SamVerschueren where the editor sometimes remove a changes that was just made.

It's caused by the debounce which delay when the document is updated. However, the document might also be updated in the meantime by something else: here the scroll.

When the scroll position changes, the document will be updated which then cause the useEffect hook which calls setEditorDocument to be called and it would then think that the document has changed given the editor state content and the document content are different. So it resets the cursor to the beginning which is incorrect. With this PR, we ignore external scroll position changes as they are expected to be entirely controlled by the editor.

Note that there still could be a bug if an external component was also editing the editor state as if you keep pressing the same key you essentially prevent the document from ever being updated.

Before:

now.webm

After:

after.webm

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f7aa32f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[SamVerschueren]

Great find 😱 ! Now it all makes sense why this happened. Because when I pasted something that was larger than the edtior size, scrollbars appeared causing it to reset it probably.

[Nemikolh]

@SamVerschueren Exactly! It's so subtle, it's crazy 😆