feat: make core react components easily accessible #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Nemikolh
force-pushed
the
joan/react-components-minor-improvements
branch
from
a2e0799 to
2ae790d
Compare
Deploying tutorialkit-demo-page with
|
| Latest commit: |
78890e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1bf8d7a7.tutorialkit-demo-page.pages.dev |
| Branch Preview URL: | https://joan-react-components-minor.tutorialkit-demo-page.pages.dev |
Nemikolh
commented
Jun 28, 2024
| @@ -176,13 +178,15 @@ export function CodeMirrorEditor({ | |||
| }, [doc]); | |||
|
|
|||
| return ( | |||
| <div className="h-full relative"> | |||
There was a problem hiding this comment.
I've moved the responsability of setting the height to the caller. While working on an example where we wanted a fix height, this felt nicer than to wrap it in a div.
However, maybe in the majority of use cases, h-full is preferred. So maybe we should default className to h-full? I'm not sure.
Nemikolh
commented
Jun 28, 2024
Comment on lines
-2
to
-3
| export * from './CodeMirrorEditor/index.js'; | ||
| export * from './FileTree.js'; |
There was a problem hiding this comment.
Removed those exports because they're not used at the moment and the intent is to have them imported via the /core module.
…-minor-improvements
Deploying tutorialkit-docs-page with
|
| Latest commit: |
97ab5ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3361bdb6.tutorialkit-docs-page.pages.dev |
| Branch Preview URL: | https://joan-react-components-minor.tutorialkit-docs-page.pages.dev |
AriPerkkio
reviewed
Jun 28, 2024
AriPerkkio
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a bit the
@tutorialkit/react-componentsso that theCodeMirrorEditor,TerminalandFileTreecan be easily accessed under a/coremodule:Given that the
Terminalcomponent is not SSR friendly because of@xterm, it is also possible to import the component individually, via/core/<component name>and both default and named exports are provided:(in the astro integration we lazy import the terminal with a dynamic import and add a
<Suspense>boundary to make it work)